It seems modern Firefox needs the keepalive or it will close at 30s#368
Open
monkeyiq wants to merge 1 commit into
Open
It seems modern Firefox needs the keepalive or it will close at 30s#368monkeyiq wants to merge 1 commit into
monkeyiq wants to merge 1 commit into
Conversation
|
This indeed fix the issue we had at the office. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that modern Firefox browsers need to have the
keepAlivefunction running or they will close the service worker after around 30 seconds. If you are performing longer transfers the sw closes and you may stillpumpdata to be saved but it will be silently ignored.This partial download is reported in the issue at #366
This was reported to the FileSender project which can use StreamSaver to store in browser decrypted data to disk. See the issue at filesender/filesender#2575
Without the change downloading is "finished" after 30 seconds of streaming (however many bytes are transferred) and with the change I can stream a download that takes 6 minutes to complete. I will test for even longer in case
keepAliveis needed elsewhere.