Optional kafka segment configs #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: bulkerapp/app/topic_manager.go
|
Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic. |
absorbb
reviewed
Sep 24, 2025
kafkabase/kafka_config.go
Outdated
| config["segment.ms"] = fmt.Sprint(c.KafkaTopicSegmentHours * 60 * 60 * 1000) | ||
| } | ||
| default: | ||
| config["compression.type"] = c.KafkaTopicCompression |
There was a problem hiding this comment.
We should set "compression.type" for all modes with map init
absorbb
reviewed
Sep 24, 2025
kafkabase/kafka_config.go
Outdated
|
|
||
| switch mode { | ||
| case "retry": | ||
| config["retention.ms"] = fmt.Sprint(c.KafkaTopicRetentionHours * 60 * 60 * 1000) |
There was a problem hiding this comment.
KafkaRetryTopicRetentionHours
absorbb
reviewed
Sep 24, 2025
bulkerapp/app/batch_consumer.go
Outdated
|
|
||
| }() | ||
| err = bc.topicManager.ensureTopic(bc.retryTopic, 1, bc.topicManager.RetryTopicConfig()) | ||
| err = bc.topicManager.ensureTopic(bc.retryTopic, 1, bc.topicManager.config.TopicConfig("retry")) |
There was a problem hiding this comment.
bc has config property too
absorbb
reviewed
Sep 24, 2025
bulkerapp/app/stream_consumer.go
Outdated
| failedTopic = sc.config.KafkaDestinationsDeadLetterTopicName | ||
| } else { | ||
| err = sc.topicManager.ensureTopic(sc.retryTopic, 1, sc.topicManager.RetryTopicConfig()) | ||
| err = sc.topicManager.ensureTopic(sc.retryTopic, 1, sc.topicManager.config.TopicConfig("retry")) |
There was a problem hiding this comment.
sc has config property too
|
thanks for reviewing @absorbb !! just addressed your feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to make kafka segment configs optional so bulker can work with providers that do not allow clients to set those configs, AWS MSK for example.
It introduces a new config option
KafkaAllowSegmentConfigwhich is enabled by default, same behaviour as currentmainbranch, but allow users to disable it.