fix(spec/carrier): restore truncated UPS '1Z' tracking identifier regex

[jimmy-zhening-luo]

Summary by CodeRabbit

• Bug Fixes
  • Refined UPS tracking number validation to enforce stricter format requirements for improved accuracy.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The UPS tracking regex pattern in couriers/ups.json was refined to enforce the SerialNumber component to be exactly 16 alphanumeric characters (with optional internal whitespace). This narrows the validation criteria while keeping other regex components for ShipperId, ServiceType, PackageId, and CheckDigit unchanged.

Changes

Cohort / File(s)	Change Summary
UPS Tracking Regex Refinement couriers/ups.json	Narrowed tracking_numbers regex to enforce SerialNumber capture as exactly 16 alphanumeric characters with optional internal whitespace via (?<SerialNumber>(?:[A-Z0-9]\s*){16,16}). Other regex components (ShipperId, ServiceType, PackageId, CheckDigit) remain unaffected.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Areas requiring attention:

• Verify the quantifier {16,16} correctly enforces exactly 16 characters when optional whitespace is interspersed between characters
• Confirm the refined pattern does not invalidate previously accepted UPS tracking numbers
• Test edge cases with varying whitespace patterns within the SerialNumber capture group

Poem

🐰 A regex hops with precision keen,
Sixteen digits, crisp and clean,
UPS tracking now sharper, more tight,
No false positives in the night!
From CodeRabbit's burrow, this fix takes flight! 🚚✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references the main change: restoring a UPS tracking identifier regex that was truncated, which aligns with the file modification in couriers/ups.json.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 802d8a5 and 2cca06b.

📒 Files selected for processing (1)

• couriers/ups.json (1 hunks)

🔇 Additional comments (2)

couriers/ups.json (2)

9-13: Confirm the SerialNumber change is intentional and aligns with the fix objective.

The modification constrains SerialNumber to exactly 16 characters via the {16,16} quantifier, which aligns with the PR title "restore truncated UPS '1Z' tracking identifier regex"—indicating this is narrowing the validation to enforce the correct documented length. Ensure this change doesn't invalidate any real-world tracking numbers that your tracking_number_data library supports.

To confirm this change is correct, verify:

• UPS official documentation specifies the SerialNumber component is exactly 16 characters long
• No existing test or production tracking numbers are affected negatively by enforcing exactly 16 characters

---

9-9: Verify the regex pattern correctly matches the test numbers.

The modified SerialNumber pattern enforces exactly 16 alphanumeric characters (with optional internal whitespace). However, based on the component structure shown, the complete regex may require more characters than the test numbers contain. The regex matching behavior and JSON structure validity require verification against the actual file content.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jimmy-zhening-luo]

I am using web editor and it seems to not save my changes correctly. Resubmitting.

[jimmy-zhening-luo]

Ahh okay never mind, I get it now after reading the other carrier manifests. The array of strings gets joined into a regex.