Skip to content

Added initial support for the HydraSDR RFOne - #409

Open
kit-repo-depot wants to merge 3 commits into
jketterl:developfrom
kit-repo-depot:owrx-add-rfone
Open

Added initial support for the HydraSDR RFOne#409
kit-repo-depot wants to merge 3 commits into
jketterl:developfrom
kit-repo-depot:owrx-add-rfone

Conversation

@kit-repo-depot

Copy link
Copy Markdown

See https://github.com/hydrasdr for details about building the library and
Soapy module required to support the hardware. There's an issue in the
upstream library with a fix described in hydrasdr/hydrasdr-host#5

See https://github.com/hydrasdr for details about building the library and
Soapy module required to support the hardware. There's an issue in the
upstream library with a fix described in hydrasdr/hydrasdr-host#5
Comment thread owrx/source/hydrasdr.py Outdated
return "hydrasdr"


class HydraSDRDeviceDescription(SoapyConnectorDeviceDescription):

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class name is not in line with the rest of the code. The class names must convert from the snake_case name you use in the configuration ("hydrasdr") into CamelCase. This class must therefor be named HydrasdrDeviceDescription.

Please update.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it's updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants