Skip to content

Allow accept header to be specified alongside profileURL #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BlakeWilliams wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow accept header to be specified alongside profileURL #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/lib/hash-params.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ test('getHashParams', () => {
expect(getHashParams('#title=hello%20world')).toEqual({
title: 'hello world',
})
expect(getHashParams('#profileAccepts=application%2Fjson')).toEqual({
profileAccepts: 'application/json',
})
expect(getHashParams('#abc=bcd')).toEqual({})
expect(getHashParams('garbage')).toEqual({})
})
3 changes: 3 additions & 0 deletions src/lib/hash-params.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {ViewMode} from '../lib/view-mode'

export interface HashParams {
profileURL?: string
profileAccepts?: string
title?: string
localProfilePath?: string
viewMode?: ViewMode
Expand Down Expand Up @@ -36,6 +37,8 @@ export function getHashParams(hashContents = window.location.hash): HashParams {
result.title = value
} else if (key === 'localProfilePath') {
result.localProfilePath = value
} else if (key === 'profileAccepts') {
result.profileAccepts = value
} else if (key === 'view') {
const mode = getViewMode(value)
if (mode !== null) {
Expand Down
11 changes: 9 additions & 2 deletions src/views/application.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ export class Application extends StatelessComponent<ApplicationProps> {
}

async maybeLoadHashParamProfile() {
const {profileURL} = this.props.hashParams
const {profileURL, profileAccepts} = this.props.hashParams
if (profileURL) {
if (!canUseXHR) {
alert(
Expand All @@ -433,7 +433,14 @@ export class Application extends StatelessComponent<ApplicationProps> {
return
}
this.loadProfile(async () => {
const response: Response = await fetch(profileURL)
const fetchOpts: RequestInit = {}
if (profileAccepts) {
fetchOpts['headers'] = {
Accept: profileAccepts,
}
}

const response: Response = await fetch(profileURL, fetchOpts)
let filename = new URL(profileURL, window.location.href).pathname
if (filename.includes('/')) {
filename = filename.slice(filename.lastIndexOf('/') + 1)
Expand Down