Add Perfetto trace import support with protobuf integration#517
Open
jlfwong wants to merge 1 commit into
Open
Conversation
- Add Perfetto protobuf definitions and generated code - Implement importFromPerfettoTrace function - Integrate Perfetto trace import in importProfileGroupFromText - Add sample Perfetto trace file and generation script - Add integration tests for Perfetto trace import This enables importing and processing Perfetto trace files (.perfetto-trace, .pftrace) in the profiling tool. Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.perfetto-traceand.pftracefor automatic detectionChanges
Core Import Functionality
perfetto.protoprotobuf schema and generated JS/TS bindingsimportFromPerfettoTraceto parse Perfetto trace dataSample and Test
sample/profiles/perfetto/simple.perfetto-tracescripts/generate-perfetto-sample.jsto generate the sample trace fileperfetto-integration.test.tswith tests for importing Perfetto traces by filename and extensionProtobuf Integration
Test plan
This PR enables Speedscope to handle Perfetto trace files, expanding its compatibility with popular tracing formats.
🌿 Generated by Terry
ℹ️ Tag @terragon-labs to ask questions and address PR feedback
📎 Task: https://www.terragonlabs.com/task/9a3333d4-48b1-4b5c-81e3-945192ea732f
Fixes #516