fix: Safari 26.4 timeline export support#551
Merged
Merged
Conversation
agurtovoy
commented
May 13, 2026
| sampleDurations: number[] | ||
| } | ||
| | { | ||
| samples: Sample[] |
Contributor
Author
There was a problem hiding this comment.
The new format moves sampleStackTraces and sampleDurations into the samples array (e.g. samples: [{ stackTraces: [], durations: []}])
Contributor
Author
|
Quick demo showing that this doesn't break support for the old format: Kapture.2026-05-13.at.16.51.58.mp4 |
Owner
|
Hi @agurtovoy! Thanks for the patch. Can you please add a snapshot test that imports the newly added sample/profiles/Safari/26.4/simple.html-recording.json? |
Contributor
Author
|
@jlfwong Done! |
|
coverage: 43.805% (+0.07%) from 43.737% — agurtovoy:main into jlfwong:main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the great tool, super helpful!
At some point Safari changed its export format without bumping up the version. This PR adds support for Safari 26.4 timeline export while remaining backward compatible with the older format.