Parse time when creating revision from API response#7
Open
gregates wants to merge 1 commit intojmthrower:masterfrom
Open
Parse time when creating revision from API response#7gregates wants to merge 1 commit intojmthrower:masterfrom
gregates wants to merge 1 commit intojmthrower:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I expect that having a string here is probably fine for most purposes, when re-creating a function to extract the latest revision from a spreadsheet's revisions collection, I was parsing the created_at field myself so I could compare actual Time objects instead of mere Strings. Thought it might be worth having the timestamp field on the model always return a Time object, as I was initially expecting this to be its type.