Fix Broken unit tests and improve cross platform support in file helpers#11
Open
lucky5th wants to merge 14 commits into
Open
Fix Broken unit tests and improve cross platform support in file helpers#11lucky5th wants to merge 14 commits into
lucky5th wants to merge 14 commits into
Conversation
lucky5th
commented
Jul 23, 2026
lucky5th
commented
Contributor
- Change safeResolvePath to normalize filename and memoryDir early
- Update regex assertions to match unix or win32 path separator patterns
- Added block absolute win32 paths
- Extended bloack absolute paths to handle forward slashes case
- Pass paths through path.normalize in assertions and parameters
- Added .editorconfig to ensure consistent spacing.
Add support for HOMEPATH environment variable present when running in Windows. Resolves issue where pi-mem will create a directory `./~/` in the pi agents directory and in the current working directory on Windows systems.
Use os.homedir() instead of bash tilde expansion to consistently resolve home directory in Windows and Linux environments
… user's home directory. Pass through path.normalize() to ensure resolve paths and expected paths use the same path separator accross platforms.
- Change safeResolvePath to normalize filename and memoryDir early - Update regex assertions to match unix or win32 path separator patterns - Added block absolute win32 paths - Extended bloack absolute paths to handle forward slashes case - Pass paths through path.normalize in assertions and parameters
- Added defensive code in resolveHomeDir and resolveAgentDir to handle case where null is passed to fallback argument - Added coverage for when no fallback argument is provided - Added coverage for when null is passed to fallback argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.