-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix - correct typeFullName for member with generic type, issue 105 #2797
Conversation
joern-cli/frontends/javasrc2cpg/src/main/scala/io/joern/javasrc2cpg/passes/AstCreator.scala
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
@fabsx00 Have raised a new commit which persists the generic information in typeFullName |
I haven't had much time to look into this, but also check this thread: #2655 |
Can you elaborate? What is the effect of this change now that |
@DavidBakerEffendi Thanks for the thread, I went over it. To frame my understanding, two points which are related to this PR. Regarding 2nd point, earlier this PR was made based on a similar understanding of not including generics in typeFullName, but as per a comment by @fabsx00, I have modified the PR to include the generics in typeFullName as well. Open to further discussion |
Yes, In earlier version of this PR the typeFullName for
was now with further change as per your comment it is The reason for the PR was the |
Observed some fluke with a jssrc test here, but this one doesn't touch jssrc, so, that seems unrelated. |
No description provided.