Move away from find_packages() to explicitly declaring the package. #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaitaiwan I think this one might be a priority to ship along with the fixes I've brushed up tonight. I started a 2.0 milestone and tagged PRs that I think we need to look into or get merged. What are your thoughts on pushing out a 1.9 release and then 2.0 when PT3K is done along with the other PRs? (I also have finished auditing all of the issues. Lots of duplicates.) |
|
Agreed. LGTM |
joestump
added a commit
that referenced
this pull request
Jul 29, 2015
Move away from find_packages() to explicitly declaring the package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87. The
find_packages()function was picking up thetests/directory and pollutingsite-packageswith atests/directory. 😯