feat: custom airports (and new airport data source) #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* it seems like there is a bug in esbuild that prevents building the project in a Docker environment, when using $state.raw class fields. * Using one nested $state solves the problem so that is what I did
…e/ourairports # Conflicts: # bun.lockb # src/lib/components/map/AirportLayer.svelte # src/lib/components/map/FlightArcLayer.svelte # src/lib/components/map/state.svelte.ts # src/lib/components/modals/settings/pages/security-page/ApiKeys.svelte # src/lib/utils/data/airports/source.ts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update does include a breaking change for people who have flights from/to a any few hundred airports, as the old data source had incorrect (or outdated) ICAO codes for those airports, and the new source has the correct ones (which do not line up with the ICAO code saved in AirTrail. A simple fix would be to either re-create the flights that show N/A airport, or create a custom airport with the old ICAO code.
The most notable airports are:
Kuwait International Airport
Jorge Chávez International Airport
Manas International Airport
Dabolim Airport
Hazrat Shahjalal International Airport