Added autoUpdate functionality #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When 'autoUpdate' is enabled, the mask will be automatically re-applied whenever the display list changes.
I figured it would probably be better this way for backwards-compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autoUpdate is enabled, the mask will be re-applied anytime the display list changes. It is off by default for backwards-compatibility. autoUpdate works by overridding methods such as addChild and removeChild. This means that if someone was to repeatedly call those methods (in a loop for example) there would be a performance impact.
I decided to add the autoUpdate param in the constructor. I think it makes sense but I'll let you decide. Cheers!