-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.1] New backend Joomla! Help page #46355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.1-dev
Are you sure you want to change the base?
Conversation
|
Looks good |
|
It works but I am having second thoughts about how I have coded this feature. Perhaps it should be considered a draft for now. I will get on to the points raised by @brianteeman - thank you. Meanwhile, here is a screenshot:
|
|
@brianteeman Should I make the copyright 2026 on the assumption it will be next year before it appears? |
no - you wrote it in 2025 and it will hopefully be merged on github in 2025 |
|
You could remove the need for the |
|
@C-Lodder only just seen your suggestion - I will give it a try. |
|
@C-Lodder I implemented you suggestion. Next problem: In narrow screens the Help menu starts open and it takes two clicks to close it. I want it to start with the Help menu closed. Also, in narrow screen mode I want the Help menu to close after selecting an item. I am looking in to how to do this - do you have any suggestions? |
|
I am happy! This PR is ready for testing. |
|
@ceford What about these 2 unresolved review comments by @brianteeman ?
If they are resolved, please use the button below the comment on GitHub to mark it as resolved. With the other 2 about the copyright year I've just done that. Thanks in advance. |
Done that! As I am a rare contributor I did not realised that I needed to resolve comments. I also addressed the alignment problem mentioned by Brian |
|
@ceford Thanks. It is not necessarily the author of a PR who has to resolve review comments, it can also be done by the initial reviewer or by a maintainer. But at the end it is good to have them resolved, otherwise GitHub shows a message about unresolved comments which might discourage testers because they might think there will be more changes coming. |
| COM_ADMIN_HELP_FIELD_GROUPS="Field Groups" | ||
| COM_ADMIN_HELP_FIELDS:_EDIT="Fields: New/Edit" | ||
| COM_ADMIN_HELP_FIELDS="Fields" | ||
| COM_ADMIN_HELP_FRAME_TITLE="Frame for Help Pages" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as you don't give an alt title = image of cat you don't give an iframe a title= iframe of cat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the title to "Structured list of Help Pages". Edit: but that is not right because the frame does not contain a list. Thinking again!
Now changed to "Last selected Help Page"
| /** @var Joomla\CMS\WebAsset\WebAssetManager $wa */ | ||
| $wa = $this->getDocument()->getWebAssetManager(); | ||
| $wa->useScript('com_admin.admin-help'); | ||
| $wa->addInlineStyle(' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you using an inline style and not a css file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have thought about this! If someone would like to create a template override it would be easier(?) to change the various styles in the override. The same argument applies to the toc-src.php file which sets the content and order of the help pages menu. Someone might wish to use an override or a child to create a custom list for a selected user group. I can move the styles to a css file if that is preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be better (and more consistent) as a separate file
|
There is a snag! The rebase to 6.1 has led to the proxy returning 404 not found pages. For test purposes you can edit configuration.php and set the minor version to 0 |


Pull Request for Issue # .
No issue in the tracker but the problematic list of Help pages has been mentioned in discussions.
Summary of Changes
This PR is for a replacement of the backend list of Help files accessed via Help → Start Here. The current page presents a list of 198 items sorted into alphabet order of the language selected at login. It is very difficult to use! Each time the page is reloaded the displayed item is Start Here. Also, it is generated by a script that fetches all the pages from docs.joomla.org that are categorised as Help5 or Help6 or ... but only in selected languages.
The proposed replacement gives the list of Help pages a similar structure to the Atum side menu. The changes in brief:
There is a potential problem: initialisation of the Help menu requires a delay or it is left inoperative. That needs testing on different platforms.
Testing Instructions
Testing needs a development installation.
this is because the proxy is not configured to deliver Help pages for 6.1
Actual result BEFORE applying this Pull Request
The current long alphabetic list of Help pages is difficult to use.
Expected result AFTER applying this Pull Request
The list of help pages is structured with a Metismenu. Screenshot to follow.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
[ x] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[x ] No documentation changes for manual.joomla.org needed