Skip to content

Conversation

@ceford
Copy link
Contributor

@ceford ceford commented Oct 23, 2025

Pull Request for Issue # .

No issue in the tracker but the problematic list of Help pages has been mentioned in discussions.

Summary of Changes

This PR is for a replacement of the backend list of Help files accessed via Help → Start Here. The current page presents a list of 198 items sorted into alphabet order of the language selected at login. It is very difficult to use! Each time the page is reloaded the displayed item is Start Here. Also, it is generated by a script that fetches all the pages from docs.joomla.org that are categorised as Help5 or Help6 or ... but only in selected languages.

The proposed replacement gives the list of Help pages a similar structure to the Atum side menu. The changes in brief:

  1. The Help page menu source is a handcrafted php array (toc-src.php) in the tmpl folder.
  2. The menu build code has been moved from the Model to the tmpl folder (toc-build.php).
  3. Unused code has been removed from the Model.
  4. Unused code has been removed from the HtmlView.
  5. The unused administrator/help/en-GB/toc.json tree has been deleted.
  6. The now unused build/helpTOC.php has been deleted.
  7. There are additional strings in com_admin.ini
  8. Changes to admin-help.es6.js are significant.
  9. There is styling added in default.php with addInlineStyle() to distinguish the Help menu from the Atum menu.
  10. The last page displayed is recorded in local storage and displayed when the page is reloaded.

There is a potential problem: initialisation of the Help menu requires a delay or it is left inoperative. That needs testing on different platforms.

Testing Instructions

Testing needs a development installation.

Actual result BEFORE applying this Pull Request

The current long alphabetic list of Help pages is difficult to use.

Expected result AFTER applying this Pull Request

The list of help pages is structured with a Metismenu. Screenshot to follow.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [ x] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [x ] No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.1-dev labels Oct 23, 2025
@brianteeman
Copy link
Contributor

Looks good

@brianteeman
Copy link
Contributor

When the menu item wraps to two lines I find the center alignment visually awkward but that might just be me

image

@richard67 richard67 changed the title New backend Joomla! Help page [6.1] New backend Joomla! Help page Oct 23, 2025
@ceford
Copy link
Contributor Author

ceford commented Oct 23, 2025

It works but I am having second thoughts about how I have coded this feature. Perhaps it should be considered a draft for now. I will get on to the points raised by @brianteeman - thank you. Meanwhile, here is a screenshot:

image

@ceford
Copy link
Contributor Author

ceford commented Oct 23, 2025

@brianteeman Should I make the copyright 2026 on the assumption it will be next year before it appears?

@brianteeman
Copy link
Contributor

@brianteeman Should I make the copyright 2026 on the assumption it will be next year before it appears?

no - you wrote it in 2025 and it will hopefully be merged on github in 2025

@C-Lodder
Copy link
Member

C-Lodder commented Oct 24, 2025

You could remove the need for the wait() delays if you wanted to.
Will leave this code here incase you want to use it.

document.addEventListener("DOMContentLoaded", function (event) {
  new MetisMenu('#helpmenu', {
    toggle: true
  });

  const helpIndex = document.getElementById('helpmenu');
  if (helpIndex) {
    helpIndex.querySelectorAll('a:not(.has-arrow)').forEach(element => element.addEventListener('click', () => {
      window.scroll(0, 0);
      // Save clicked link data-id
      const id = element.dataset.id;
      if (id) {
        localStorage.setItem('helpIndex.lastClick', id);
      }
    }));
  }

  // Async restore function
  function restoreMenu() {
    let lastClick = localStorage.getItem('helpIndex.lastClick');
    if (!lastClick) {
      lastClick = 'start-here';
    }

    const selectedLink = helpIndex.querySelector(`a[data-id="${lastClick}"]`);
    if (!selectedLink) return;

    // Collect parent list items top-down
    const lists = [];
    let parentLi = selectedLink.closest('li');
    while (parentLi && parentLi !== helpIndex) {
      const parentUl = parentLi.parentElement;
      const parentLiOfUl = parentUl.closest('li');
      if (parentLiOfUl) {
        const li = parentLiOfUl
        if (li) lists.unshift(li);
      }
      parentLi = parentLiOfUl;
    }

    // Trigger clicks in sequence with a delay
    for (const li of lists) {
      li.classList.add('mm-active');
      li.querySelector('ul').classList.add('mm-show');
      li.querySelector('a').setAttribute('aria-expanded', true);
    }

    // Optional: highlight selected link
    selectedLink.classList.add('active');

    // Ensure it's visible and then "click" it
    //selectedLink.scrollIntoView({ behavior: 'smooth', block: 'start' });

    // Give the submenu a moment to fully render before clicking
    selectedLink.click();
  }

  // Run restore after MetisMenu setup delay
  restoreMenu()
});

@ceford
Copy link
Contributor Author

ceford commented Oct 24, 2025

@C-Lodder only just seen your suggestion - I will give it a try.

@ceford
Copy link
Contributor Author

ceford commented Oct 24, 2025

@C-Lodder I implemented you suggestion. Next problem: In narrow screens the Help menu starts open and it takes two clicks to close it. I want it to start with the Help menu closed. Also, in narrow screen mode I want the Help menu to close after selecting an item. I am looking in to how to do this - do you have any suggestions?

@ceford
Copy link
Contributor Author

ceford commented Oct 24, 2025

I am happy! This PR is ready for testing.

@richard67
Copy link
Member

@ceford What about these 2 unresolved review comments by @brianteeman ?

If they are resolved, please use the button below the comment on GitHub to mark it as resolved.

With the other 2 about the copyright year I've just done that.

Thanks in advance.

@ceford
Copy link
Contributor Author

ceford commented Oct 24, 2025

@ceford What about these 2 unresolved review comments by @brianteeman ?

* [[6.1] New backend Joomla! Help page #46355 (comment)](https://github.com/joomla/joomla-cms/pull/46355#discussion_r2454333605)

* [[6.1] New backend Joomla! Help page #46355 (comment)](https://github.com/joomla/joomla-cms/pull/46355#discussion_r2454339366)

If they are resolved, please use the button below the comment on GitHub to mark it as resolved.

With the other 2 about the copyright year I've just done that.

Thanks in advance.

Done that! As I am a rare contributor I did not realised that I needed to resolve comments. I also addressed the alignment problem mentioned by Brian

@richard67
Copy link
Member

@ceford Thanks. It is not necessarily the author of a PR who has to resolve review comments, it can also be done by the initial reviewer or by a maintainer. But at the end it is good to have them resolved, otherwise GitHub shows a message about unresolved comments which might discourage testers because they might think there will be more changes coming.

COM_ADMIN_HELP_FIELD_GROUPS="Field Groups"
COM_ADMIN_HELP_FIELDS:_EDIT="Fields: New/Edit"
COM_ADMIN_HELP_FIELDS="Fields"
COM_ADMIN_HELP_FRAME_TITLE="Frame for Help Pages"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as you don't give an alt title = image of cat you don't give an iframe a title= iframe of cat

Copy link
Contributor Author

@ceford ceford Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the title to "Structured list of Help Pages". Edit: but that is not right because the frame does not contain a list. Thinking again!

Now changed to "Last selected Help Page"

/** @var Joomla\CMS\WebAsset\WebAssetManager $wa */
$wa = $this->getDocument()->getWebAssetManager();
$wa->useScript('com_admin.admin-help');
$wa->addInlineStyle('
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you using an inline style and not a css file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have thought about this! If someone would like to create a template override it would be easier(?) to change the various styles in the override. The same argument applies to the toc-src.php file which sets the content and order of the help pages menu. Someone might wish to use an override or a child to create a custom list for a selected user group. I can move the styles to a css file if that is preferred.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better (and more consistent) as a separate file

@ceford
Copy link
Contributor Author

ceford commented Oct 24, 2025

There is a snag! The rebase to 6.1 has led to the proxy returning 404 not found pages. For test purposes you can edit configuration.php and set the minor version to 0

public $helpurl = 'https://help.joomla.org/proxy?keyref=Help{major}0:{keyref}&lang={langcode}';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-6.1-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants