Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would be a breaking change. Today, the
Eventis a concrete type that internally uses aHashMap. This may be a problem for low-latency applications, where having to create an event from other data structures may be problematic (image applications that have different rules engines and may need to allocate to each different rule engine "event").Ultimately, what we really want is the ability to query the data structure, so anything that conforms to such an API should work for the crate. This PR introduces a
QueryableEventtrait, which is implemented byEvent. TheQueryableEventcan be implemented by the crate users for their different structs instead of forcing them to convert to asigma_rust::Event.