-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Stringify for nums bigger than max safe integer #1646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Pavel, I think it makes sense to parse a bigint into a string rather than a number which loses digits.
I made a few inline comments, can you have a look at those?
This reverts commit a639d83.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates Pavel, this looks good indeed! One small remark left, can you have a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like how this PR turned out :)
Hi, @josdejong can you tell if there will be a new version with these changes? I also saw a small typo in the history file on line 8, there is a different nickname there :) |
Ah, sorry about that, I've fixed it via d56659a. I've just published |
Thanks a lot, great news! |
Hi, I've made fixes for two problems, discussed here #1259
1: Trying to paste big number like
7405242042266046865
, that incorectly converts it to number, because it bigger that max safe integer.Before: https://github.com/user-attachments/assets/7869e787-c2da-4d1c-ac20-0e7243720148
After: https://github.com/user-attachments/assets/be9029f3-b726-4eb5-8c52-3e9bf4cfd798