Add youtube video to about #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All items in the checklist have been checked🎉 |
Contributor
|
@josh-wong Not all items in the checklist have been checked👀 Please review the unchecked items in the PR description. |
Contributor
|
All items in the checklist have been checked🎉 |
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the react-lite-youtube-embed library to add a YouTube video embed on the About Me page, styles the embed for responsiveness and centering, and surfaces a new notification in the site header.
- Added
react-lite-youtube-embeddependency and imported its CSS. - Embedded the YouTube video within a
<details>block onabout/index.mdx. - Introduced
.youtube-embedCSS rules and a new notification entry in the header.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/pages/about/index.mdx | Imported LiteYouTubeEmbed and wrapped the video in a <details> element. |
| src/css/custom.css | Added .youtube-embed rules for layout and sizing. |
| package.json | Added react-lite-youtube-embed dependency. |
| docusaurus.config.js | Added notification for the "Life + Data" episode. |
Contributor
|
All items in the checklist have been checked🎉 |
josh-wong
force-pushed
the
add-youtube-video-to-about
branch
from
da39239 to
a41acf3
Compare
Contributor
|
All items in the checklist have been checked🎉 |
Contributor
|
All items in the checklist have been checked🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new feature to embed YouTube videos on my "About Me" page and includes associated styling and dependency updates. The changes focus on integrating the
react-lite-youtube-embedlibrary, styling the embed component, and adding a YouTube video embed for my episode on the "Life + Data" show.Related issues and/or PRs
N/A
Changes made
react-lite-youtube-embedlibrary topackage.jsonto enable lightweight YouTube embedding. (package.json).youtube-embedCSS class tocustom.cssfor styling the YouTube embed, ensuring proper alignment and responsiveness. (src/css/custom.css)react-lite-youtube-embedcomponent on the "About Me" page, wrapped in a<details>element for better user experience. Also imported the library's CSS for styling. (src/pages/about/index.mdx)Checklist
The following is a best-effort checklist. If any items in this checklist aren't applicable to this PR, add
N/Aafter each item.Documentation
N/AN/ABuild, deploy, and test
N/AN/A