Add nightly feature #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for taking the time to implement this, and show how it could work with nightly Rust. I would prefer to avoid maintaining parallel support for nightly Rust, though; I would rather wait for PidFd support in std to be stable. At that point, though, I will definitely switch to it, and drop a substantial amount of code from this crate. (I may use the nightly portion of your PR at that point.) I'm also hoping that OwnedFd and BorrowedFd become stable around the same time, so that I can stop using RawFd. I may also bump the version to 1.0 at that time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
nightlyfeature which uses the recently addedPidFdtype from the standard library.