Thrax 11 Publish thrax to Sonatype #12
Open
lewismc wants to merge 7 commits intojoshua-decoder:masterfrom
Open
Thrax 11 Publish thrax to Sonatype #12lewismc wants to merge 7 commits intojoshua-decoder:masterfrom
lewismc wants to merge 7 commits intojoshua-decoder:masterfrom
Conversation
Member
|
@lewismc, we're pulling Thrax into Joshua as part of the multi-core move, so that will enable an easy Maven push (joshua-thrax). Sound okay to close this out? |
Author
An attempt at setting this was in the code, but the constant was overriden with a query to the config file.
… implement slf4j-over-log4j logging
Author
|
This build has been completely converted to Maven, slf4j-over-log4j has been implemented and all forbidden API's calls have been addressed however it is not ready to be merged into master yet as
|
Author
|
@mjpost is there work going on elsewhere to Mavenize Thrax? I jsut re-read your message above... which may indicate that the work has been completed elsewhere. I hope to god that this is not the case and this PR has and is time well spent. |
Author
|
I'll wait for your reply here before continuing to investigate the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at Mavenizing Thrax with the attempt of having an artifact which can be pushed to Maven Central.
Essentially this PR does exactly that however it also does not correctly compile due to API changes within the most recent version of [jerboa|https://github.com/vandurme/jerboa/]. In particular the Classes which are affected are
@mjpost can you take a look at the APi changes and potentially implement them correctly as i am not sure what is going on.