Skip to content
This repository was archived by the owner on May 26, 2020. It is now read-only.

Pass Request from JSONWebTokenSerializer to django.contrib.auth#412

Open
jksimoniii wants to merge 5 commits into
jpadilla:masterfrom
jksimoniii:master
Open

Pass Request from JSONWebTokenSerializer to django.contrib.auth#412
jksimoniii wants to merge 5 commits into
jpadilla:masterfrom
jksimoniii:master

Conversation

@jksimoniii

Copy link
Copy Markdown

Closes #387

@codecov

codecov Bot commented Dec 21, 2017

Copy link
Copy Markdown

Codecov Report

Merging #412 into master will decrease coverage by 0.26%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
- Coverage   90.67%   90.41%   -0.27%     
==========================================
  Files          14       12       -2     
  Lines         847      824      -23     
  Branches       29       29              
==========================================
- Hits          768      745      -23     
  Misses         66       66              
  Partials       13       13
Flag Coverage Δ
#codecov 90.41% <92.85%> (-0.27%) ⬇️
#dj110 87.13% <85.71%> (-0.35%) ⬇️
#dj111 87.13% <85.71%> (-0.35%) ⬇️
#dj18 89.56% <85.71%> (-0.29%) ⬇️
#dj19 89.56% <85.71%> (-0.29%) ⬇️
#drf31 89.56% <85.71%> (-0.29%) ⬇️
#drf32 89.56% <85.71%> (-0.29%) ⬇️
#drf33 89.56% <85.71%> (-0.29%) ⬇️
#drf34 90.41% <92.85%> (-0.27%) ⬇️
#drf35 90.04% <92.85%> (-0.28%) ⬇️
#drf36 90.04% <92.85%> (-0.28%) ⬇️
#py27 90.41% <92.85%> (-0.27%) ⬇️
#py33 89.19% <85.71%> (-0.3%) ⬇️
#py34 90.04% <92.85%> (+0.55%) ⬆️
#py35 87.13% <85.71%> (?)
#py36 87.13% <85.71%> (?)
Impacted Files Coverage Δ
rest_framework_jwt/serializers.py 82.41% <100%> (ø) ⬆️
tests/test_serializers.py 95.71% <92.3%> (+0.4%) ⬆️
rest_framework_jwt/models.py
rest_framework_jwt/utils.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0bd40...a950756. Read the comment docs.

@Moulde

Moulde commented Apr 18, 2018

Copy link
Copy Markdown

Any updates on this?

@rubgombar1

Copy link
Copy Markdown

+1

2 similar comments
@mscansian

Copy link
Copy Markdown

+1

@JamesonNetworks

Copy link
Copy Markdown

+1

@mscansian

Copy link
Copy Markdown

@jpadilla is it possible to merge this PR into master?

@paymog

paymog commented Nov 27, 2019

Copy link
Copy Markdown

@jpadilla ping again, it's been almost 2 years since this was proposed. Is there anything I can do to speed things up?

EDIT: I just found #484. Guess this will never be merged.

Comment thread tests/test_serializers.py

def get_serializer(self, **kwargs):
serializer = JSONWebTokenSerializer(**kwargs)
serializer.context['request'] = Request(HttpRequest()),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the , at the end of this line a mistake? That creates a tuple for the value of serializer.context['request'] which doesn't seem quite right

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide request to contrib.auth.authenticate in serializers

7 participants