Open
Conversation
Aurora.JS is buggy The logic behind the `.desired` attribute setter was broken. I fixed it and jPlayer should now be able to switch between Aurora, HTML and Flash backends automatically. Closes jplayer#281.
Author
|
Is this repo still active or should I consider forking and maintaining my fork? Issues such as the one fixed in this PR can be really blocking for some applications =( Thanks! |
|
guess its was something else, not sure what was doing before, but editing code in those lines made it work... |
|
Please fork and maintain. Do you think this patch will fix the issue on chrome with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aurora.JS is buggy
The logic behind the
.desiredattribute setter was broken. I fixed itand jPlayer should now be able to switch between Aurora, HTML and Flash
backends automatically.
Closes #281.
EDIT: As far as I understood, this should be ok for a PR, and I should not include a minified version. Let me know if I missed something.