fixed the encoding of post_data #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
txt has to be converted into a buffer using the ISO-8859-1 encoding, otherwise there are problems with e. g. usernames or passwords containing non-ASCII characters
If the actual value for "name_kontrahent" was "John Doe", the library returned "undefinedJohn Doe" because the value wasn't initialized with an empty string.
When there is a minus sign (-) at the beginning of a line inside the "Mehrfach" field in the raw data, this was mistaken for the end of the "Mehrfach" field which resulted in the properties of "verwendungszweck" ("verwendungszweck.text", "verwendungszweck.name_kontrahent", ...) being truncated or sometimes even missing.
To fix this, we now recognize only the sequence "\r\n-\r\n" as the end of the message.
Simplified example input data:
:86:166?00GUTSCHRIFT...Hans
-Peter Meier
...resulted in "-Peter Meier" not being parsed anymore for the reference line.
…able Sticked to the existing naming conventions, even though German and English are mixed
This is necessary for PSD2 compatibility
This is necessary for PSD2 compatibility
include HIRMS (segment specific responses) in error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
txt has to be converted into a buffer using the ISO-8859-1 encoding, otherwise there are problems with e. g. usernames or passwords containing non-ASCII characters