Skip to content

Add custom type text/x-php #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add custom type text/x-php #358

wants to merge 3 commits into from
+7 −0

Conversation

@cjiso1117
Copy link

@cjiso1117 cjiso1117 commented Jan 21, 2025

Add support for text/x-php since file command use text/x-php in debian system

ref: https://cweiske.de/tagebuch/php-mimetype.htm#linux

@cjiso1117
Update custom-types.json
0593ba0 
add support for text/x-php
@cjiso1117
Copy link
Author

cjiso1117 commented Feb 6, 2025

is PR review stuck due to broken automation?

@wesleytodd
Copy link
Member

wesleytodd commented Mar 5, 2025

No I think it was stuck due to no one reviewing it. That said, if you look here you see application/x-httpd-php which is already in our data. That article is from 2011 and I am not sure it justifies adding this type.

@cjiso1117
Copy link
Author

cjiso1117 commented Mar 6, 2025 •
edited
Loading

But file command returns text/x-php for most os in 2025, and some mimetype guessers depend on file command and system's mimetype database.

wesleytodd
wesleytodd requested changes Mar 7, 2025
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that is a valid argument. Can you add the source key with your research links?

@cjiso1117 cjiso1117 requested a review from wesleytodd April 14, 2025 07:39
@UlisesGascon UlisesGascon mentioned this pull request Nov 19, 2025
Open
11 tasks
@UlisesGascon
Copy link
Member

UlisesGascon commented Nov 25, 2025

@wesleytodd I plan to land this PR by next week

@UlisesGascon UlisesGascon self-assigned this Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@wesleytodd wesleytodd Awaiting requested review from wesleytodd

+1 more reviewer

@bjohansebas bjohansebas bjohansebas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@UlisesGascon UlisesGascon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cjiso1117 @wesleytodd @UlisesGascon @bjohansebas