Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference to type SchemaGeneratorConfiguration (typo) #23

Conversation

jochenkirstaetter
Copy link
Contributor

The sample code of ExternalReferences uses the non-existent type SchemaGenerationConfiguration instead of the available SchemaGeneratorConfiguration

There are three additional mentions in the past release notes which I didn't update.

Cheers, JoKi

@gregsdennis
Copy link
Collaborator

gregsdennis commented Jan 31, 2025

Thanks @jochenkirstaetter . You mention three updates, but I only see two.

Also, the release notes are actually in the main repo, and they're copied here as part of a build there when the reference docs are generated. The files will need to be edited at the source. I think this can be closed.

@jochenkirstaetter
Copy link
Contributor Author

jochenkirstaetter commented Jan 31, 2025

Hello @gregsdennis

Sorry, not sure how you organised your code.
I said, I didn't change three older release note entries.

Screenshot_20250131-165554.png

Anyway, the issue is a typo in the current documentation - file: schema-generation.md - and I tried to help you.

If the release notes are changed at the wrong location, ignore it. As they'll be overwritten anyways again, or?

Cheers, JoKi

@gregsdennis
Copy link
Collaborator

gregsdennis commented Jan 31, 2025

Right, so the change to schema-generation.md is fine.

The change to the release notes file needs to happen in the other repo since any change here will be overwritten.

Sorry, it was late and I thought you only changed release notes.

@jochenkirstaetter
Copy link
Contributor Author

Hi Greg,
Wonderful.
This PR looks ready for merge or am I missing anything? Should I revert the change in the file _docs/release-notes/rn-json-schema-generation.md ?

Shall I have a look at the repository and provide you another PR or how shall we proceed?
Kindly let me know.

@gregsdennis gregsdennis merged commit ef4fb67 into json-everything:main Jan 31, 2025
2 checks passed
@gregsdennis
Copy link
Collaborator

Please do open a PR for the release notes. Thank you.

@jochenkirstaetter jochenkirstaetter deleted the typo/SchemaGeneratorConfiguration branch February 3, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants