Prevent potentially dangerous behaviour within proxy script #754
+38
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@davidlehn This PR addresses a reasonable concern and has been languishing. Could you comment or commit? |
Member
|
We're no longer using the PHP proxy code, so I think this is avoided now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a user supplies a custom
"@context": "http://schema.org/"within the json-ld playground a call to a proxy script is made.This proxy script is implemented in an unsafe manner, allowing an attacker to perform XSS or CSRF attacks against the server.
I didn't find a private contact method for reporting the vulnerability, so here's directly the pull request which should harden the proxy script.
Long-term it's probably advisable to perform requests to hosts defined within
@contextcompletely client-side via JavaScript.