Made the blog images and description uniform in height #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
|
@r120dhiman Please read the comment I left on the issue. The issue hasn't been approved yet and hasn't been assigned to you. |
|
Ok sir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
#1434:
Screenshots/videos:
Screen.Recording.2025-02-28.at.02.13.59.mov
Summary
In this PR as per the requirement of the issue #1434 the size of all the images in the Blog page is made uniform.
I have added a max height if 200px on a div and wrapped the image inside the div.
To accommodate the change I have to make the overall blog card a little bigger that is 498px -> 510px.
added a height of 80px to title of the blog by which we have achieved the uniformness in the description of the blogs.
Does this PR introduce a breaking change?
The PR increases the overall UI much better and due to which the user experience becomes better.