-
-
Notifications
You must be signed in to change notification settings - Fork 374
test: added unit tests for markdownUtils hiddenElements #1994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test: added unit tests for markdownUtils hiddenElements #1994
Conversation
|
Hi @Rishi2600! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference, kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1994 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 633 633
Branches 196 196
=========================================
Hits 633 633 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @Rishi2600! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference, kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
|
Hello @Utkarsh-123github @Relequestual @DhairyaMajmudar @benjagm, hope you are doing well. |
What kind of change does this PR introduce?
hiddenElementsutility function fromlib/markdownUtils.ts.Issue Number:
Changes
Created
cypress/components/lib/markdownUtils.cy.tswith 3 test cases:Document on how you can check the code without testing (Just for documentation and clarity)
This is going to show an output like
Test Results
Testing
Also, note on pre-commit hook failure -
The pre-commit hook failed due to existing build issues unrelated to this PR:
/ambassadorspage_includes/community/programs/contractors/contractors.jsonI thought not to touch the
mainbranch without permission, so I left that.Verification steps (I've tested them all manually before commit)
Verification Steps
yarn typecheckyarn lintyarn cypress run --component --spec "cypress/components/lib/markdownUtils.cy.ts"Future Work
This PR establishes a testing pattern for markdownUtils.ts. Future PRs can add tests for:
Adds test coverage without modifying production code, using the project's existing testing infrastructure.