feat(export): allow setting paper size in pdf export#728
Open
Galaxy102 wants to merge 1 commit intojsonresume:masterfrom
Open
feat(export): allow setting paper size in pdf export#728Galaxy102 wants to merge 1 commit intojsonresume:masterfrom
Galaxy102 wants to merge 1 commit intojsonresume:masterfrom
Conversation
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (5)
lib/export-resume.js:11
- [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
{ resume: resumeJson, fileName, theme, format, papersize },
lib/export-resume.js:31
- [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
createPdf(resumeJson, fileName, theme, formatToUse, papersize, (error) => {
lib/export-resume.js:84
- [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
papersize,
lib/export-resume.js:117
- [nitpick] The parameter name 'papersize' should be renamed to 'paperSize' to follow camelCase convention.
format: papersize,
lib/export-resume.js:11
- Ensure that the new 'papersize' option is covered by tests to verify it works as expected.
{ resume: resumeJson, fileName, theme, format, papersize },
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
for non-US fellas using Letter as paper format is pretty uncommon. Thus I thought it would be great if you could pass the PDF paper size as an option.
Please let me know about anything improvable, Javascript is not my main programming language.
Cheers!