Skip to content

Use importlib.resources to locate data files #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eric-wieser wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use importlib.resources to locate data files #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions pyuca/collator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
import re
import sys
import unicodedata
import importlib.abc
import importlib.resources
from io import open
import pathlib

from .trie import Trie
from .utils import hexstrings2int
Expand Down Expand Up @@ -39,15 +42,15 @@ class BaseCollator(object):

def __init__(self, filename=None):
if filename is None:
filename = os.path.join(
os.path.dirname(__file__),
"allkeys-{0}.txt".format(self.UCA_VERSION))
filename = importlib.resources.files(__package__).joinpath("allkeys-{0}.txt".format(self.UCA_VERSION))
elif isinstance(filename, str):
filename = pathlib.Path(filename)
self.table = Trie()
self.implicit_weights = []
self.load(filename)

def load(self, filename):
with open(filename) as keys_file:
with filename.open() as keys_file:
for line in keys_file:
line = line.split("#", 1)[0].rstrip()

Expand Down