Skip to content

Commit

Permalink
Fix unit test that caused CRAN check to fail (#40)
Browse files Browse the repository at this point in the history
  • Loading branch information
jtilly authored May 25, 2021
1 parent 36bdffe commit d14a15e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Package: matchingR
Type: Package
Title: Matching Algorithms in R and C++
Version: 1.3.2
Date: 2020-12-14
Version: 1.3.3
Date: 2021-05-25
Author: Jan Tilly, Nick Janetos
Maintainer: Jan Tilly <[email protected]>
Description: Computes matching algorithms quickly using Rcpp.
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# matchingR 1.3.3

* Fixed unit test for validate functions that caused a CRAN check to fail.

# matchingR 1.3.2

* Fix vignette index.
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/test_galeshapley.R
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ test_that("Check if incorrect preference orders result in an error", {
)
})

test_that("Check if validate function", {
test_that("Check validate function", {
# generate cardinal and ordinal preferences
uM <- matrix(runif(12), nrow = 4, ncol = 3)
uW <- matrix(runif(12), nrow = 4, ncol = 3)
Expand All @@ -91,7 +91,7 @@ test_that("Check if validate function", {
expect_error(galeShapley.validate(proposerPref = prefM, reviewerPref = prefW))

# generate cardinal and ordinal preferences
uM <- matrix(runif(12), nrow = 4, ncol = 4)
uM <- matrix(runif(16), nrow = 4, ncol = 4)
uW <- matrix(runif(12), nrow = 4, ncol = 3)
prefM <- sortIndex(uM)
prefW <- sortIndex(uW)
Expand Down

0 comments on commit d14a15e

Please sign in to comment.