fix static init order in WebControlRelayEvents#1638
Closed
tyleretters wants to merge 1 commit intojuce-framework:masterfrom
Closed
fix static init order in WebControlRelayEvents#1638tyleretters wants to merge 1 commit intojuce-framework:masterfrom
tyleretters wants to merge 1 commit intojuce-framework:masterfrom
Conversation
Convert static inline const Identifier members to function-local statics (Meyers singleton pattern) to avoid constructing Identifier objects during C++ static initialization. The Identifier constructor needs StringPool, which may not be initialized when AU bundles are dlopen'd — causing EXC_BAD_INSTRUCTION crashes, particularly under Rosetta x86-64 translation. Affects WebSliderRelayEvents, WebToggleButtonRelayEvents, and WebComboBoxRelayEvents (14 identifiers total). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tyleretters
changed the title
Author
|
apologies, accidental PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert static inline const Identifier members to function-local statics (Meyers singleton pattern) to avoid constructing Identifier objects during C++ static initialization. The Identifier constructor needs StringPool, which may not be initialized when AU bundles are dlopen'd — causing EXC_BAD_INSTRUCTION crashes, particularly under Rosetta x86-64 translation.
Affects WebSliderRelayEvents, WebToggleButtonRelayEvents, and WebComboBoxRelayEvents (14 identifiers total).
Thank you for submitting a pull request.
Please make sure you have read and followed our contribution guidelines (.github/contributing.md in this repository). Your pull request will not be accepted if you have not followed the instructions.