Refactor HandoverStorage to use Eigen::RowMatrixXd for improved performance#6
Open
jungdaesuh wants to merge 7 commits intomainfrom
Open
Refactor HandoverStorage to use Eigen::RowMatrixXd for improved performance#6jungdaesuh wants to merge 7 commits intomainfrom
jungdaesuh wants to merge 7 commits intomainfrom
Conversation
…rmance - Migrated HandoverStorage to use Eigen::RowMatrixXd - Cleaned up unnecessary comments from Eigen migration
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Add an example that showcases how to use VMEC++'s hot-restart feature to incrementally increase the Fourier resolution of a run, similar to the radial resolution increases via `ns_array`.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| // call serial Thomas solver for every mode number individually | ||
| // Uses span accessors to pass contiguous radial slices to the solver | ||
| const int ns = m_h_.all_ar.cols(); |
There was a problem hiding this comment.
warning: narrowing conversion from 'Index' (aka 'long') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
const int ns = m_h_.all_ar.cols();
^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::vector<std::vector<double>>withEigen::RowMatrixXdfor improved cache locality and reduced pointer chasing in the radial preconditioner / tri-diagonal solverlthreed=true, saving memory for axisymmetric (2D) casesstatic_cast<std::size_t>in accessor pointer arithmetic to prevent potential integer overflow for largemn * nsproductsThis PR addresses all feedback from proximafusion#394:
Test plan