Debug jupyter-releaser issue #561
Conversation
|
Oh, |
|
Nevermind... |
|
Nope, this did not help at all:
|
|
It is quite intriguing as other repositories do not experience this issue, but I cannot put any more time into it this week. I am able to reproduce it locally too. I enabled logging by editing jupyter-releaser code locally but nothing come up in there. A laborious but possibly more fruitful approach to debugging it would be starting from a fresh cookiecutter and moving over parts of jupyter-scheduler to see what causes this behaviour. |
|
Thank you for looking into this @krassowski. |
There was a problem hiding this comment.
Pull Request Overview
This pull request aims to investigate potential impacts on the jupyter-releaser process by updating dependency versions, modifying build targets, and adjusting workflow configurations.
- Updated build and dependency requirements in pyproject.toml
- Modified build hook paths and pre-build steps
- Adjusted CI workflow with checkout version rollback and added debug commands
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Updated dependency constraints and build hook configurations |
| .github/workflows/check-release.yml | Downgraded the checkout action version and added debug commands |
Files not reviewed (2)
- MANIFEST.in: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (3)
pyproject.toml:32
- The removal of dependencies (e.g., 'jupyter_server', 'traitlets', etc.) could lead to runtime issues if these packages are required elsewhere in the code. Please confirm that these removals are intentional and that the project’s functionality is not impacted.
"jupyter_server>=1.6,<3",
.github/workflows/check-release.yml:17
- Downgrading the checkout action from v4 to v3 may result in missing features or unexpected behavior if the latest version was required by the workflow. Please verify that this change aligns with the intended release process.
- uses: actions/checkout@v3
.github/workflows/check-release.yml:18
- [nitpick] The inclusion of debug commands (e.g., 'ls -al') may be useful for troubleshooting but should be removed or conditional in production CI workflows to avoid unnecessary log noise.
- run: ls -al
References
#558
Code changes
Just blindly checking if changing this could have an impact
User-facing changes
None
Backwards-incompatible changes
None