Use new xproperty#279
Conversation
8e80491 to
765b593
Compare
765b593 to
7f94135
Compare
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
|
NOTE: In the There was a bug where In the case of used here: was not being triggered in the subsequent cell: This was supposed to catch the thrown exception and print:
printed the invalid value which shouldn't be set in the first place: This is fixed in this PR as the exception message is printed now and the value of |
| { | ||
| this->finalize(); | ||
| return std::move(*this); | ||
| } |
There was a problem hiding this comment.
Now that the chaining syntax is not available anymore, I think we shoujld keep overloads for both lvalue and rvalue references. Maybe we can simply have a singel finalize method. Even if we find a nicer initialization syntax, it won't be based on chaining move constructor since the xproperty does not know its owner type anymore.
There was a problem hiding this comment.
Actually having a single finalize method working for all kinds of reference would break the following:
auto w = std::move(my_widget).finalize();Although this code is weird and unlikely to happen, we should opt for the less surprise principle. So let's keep bothe overloads for now, ignore my previous comment.
cf. jupyter-xeus/xproperty#71