-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install latest tensorflow using pip #2263
base: main
Are you sure you want to change the base?
Conversation
I asked in a similar TF issue for a help. |
@benz0li could you maybe please test my idea? If you have a machine with a GPU (unfortunately, I don't) download the built tensorflow-notebook cuda image. And then use the container with and without GPU enabled for the container and run this snippet:
If it works well when a GPU is enabled, I will simply disable this test for cuda image. And it should fail without GPU enabled (which currently happens in the CI). |
@mathbunnyru Yes. I will get back to you soon. |
I'm happy I recently introduced a change where we first upload an image and then test it, exactly for cases like this one 🙂 |
With GPU: docker run --rm -ti --gpus all quay.io/jupyter/tensorflow-notebook python
|
Without GPU: docker run --rm -ti --runtime runc quay.io/jupyter/tensorflow-notebook python
|
Thank you! |
docker run --rm --gpus all quay.io/jupyter/tensorflow-notebook bash -c 'python -c "import tensorflow as tf"; echo $?'
docker run --rm --gpus all quay.io/jupyter/tensorflow-notebook bash -c 'python -c "import tensorflow as tf; print(tf.constant(\"Hello, TensorFlow\"))"; echo $?'
docker run --rm --gpus all quay.io/jupyter/tensorflow-notebook bash -c 'python -c "import tensorflow as tf; print(tf.constant(\"Hello, TensorFlow\")); print(tf.reduce_sum(tf.random.normal([1000, 1000])))"; echo $?'
|
Please be aware of docker run --rm --runtime runc quay.io/jupyter/tensorflow-notebook bash -c 'python -c "import tensorflow as tf; tf.constant(\"Hello, TensorFlow\")"; echo $?'
compared to docker run --rm --runtime runc quay.io/jupyter/tensorflow-notebook bash -c 'python -c "import notfound as tf"; echo $?'
|
There is no error when using a GPU. Only an informational message:
|
Thank you, @benz0li! My bad - it seems that there is no failure (rc != 0) in either case, only the warning, which causes the test to fail. |
It seems to work; failed buils happen due to conda-forge/libxml2-feedstock#145 and this is unrelated to my change |
Describe your changes
Issue ticket if applicable
Checklist (especially for first-time contributors)