feat: added --missing flag to list and remove subcommands
#1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
Apr 25, 2025
jupyter_client/kernelspecapp.py
Outdated
| for k, v in specs.items() | ||
| # If have kernel installed from current environment | ||
| # Probably not the best way to do this, but it works in edge cases I've run into. | ||
| if (prog := v["spec"]["argv"][0]) != "python" and not Path(prog).exists() |
There was a problem hiding this comment.
This should use shutil.which to resolve things on $PATH, since it is not a requirement that argv[0] is an absolute path.
Now use `shutil.which` to check missing kernels. This catches things like "python" or "bash"
wpk-nist-gov
commented
May 1, 2025
Comment on lines
+377
to
+383
| missing: dict[str, t.Any] = {} | ||
| for name, data in specs.items(): | ||
| exe = data["spec"]["argv"][0] | ||
| # if exe exists or is on the path, keep it | ||
| if Path(exe).exists() or which(exe): | ||
| continue | ||
| missing[name] = data |
There was a problem hiding this comment.
This should address if the path exists or is on the path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1018.
This adds a flag
--missingtolistandremovesubcommands ofjupyter kernelspec. By "missing", we mean that the interpreter (the first argument of spec["spec"]["argv"] of the json specification) does not exist. This simplifies removing kernels pointing to missing environments.I'm not sure how best to test this functionality. Basic smoke tests seem to work. I'm happy to put some more work into this if it seems worthwhile to include in
jupyter-client.Thanks!