Start working on mutation issues in validate. #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @echarles |
|
@Carreau I have just looked at the code change (not tested).
|
It should have called the private |
Carreau
force-pushed
the
nbv
branch
2 times, most recently
from
e0dbd39
to
43ea02c
Compare
|
Rebased, test added and cleanup. |
We change the validation logic and separate the normalisation from the validation step. We make sure that if a notebook is normalized, it emits a warning. In the future we will turn the warning in to an Error. We add test for the current and an xfail test for the future behavior
Carreau
added a commit
to Carreau/jupyter_notebook
that referenced
this pull request
Nov 23, 2021
See jupyter/nbformat#236 and https://github.com/jupyter/nbformat/issue/235. This mostly affects frontends that do not always add ids to cells, like classic notebook, and that issue is not limited to cells ids, but also to empty cells, that may not have/need a trusted field. But that is another issue.
Carreau
added a commit
to Carreau/jupyter_notebook
that referenced
this pull request
Nov 23, 2021
See jupyter/nbformat#236 and https://github.com/jupyter/nbformat/issue/235. This mostly affects frontends that do not always add ids to cells, like classic notebook, and that issue is not limited to cells ids, but also to empty cells, that may not have/need a trusted field. But that is another issue.
Carreau
added a commit
to Carreau/jupyter_notebook
that referenced
this pull request
Nov 23, 2021
See jupyter/nbformat#236 and https://github.com/jupyter/nbformat/issue/235. This mostly affects frontends that do not always add ids to cells, like classic notebook, and that issue is not limited to cells ids, but also to empty cells, that may not have/need a trusted field. But that is another issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 toward #235