Skip to content

Added functionality for selecting multiple running items #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Axle7XStriker
Copy link
Contributor

Previously, Jupyter Notebook didn't had options for selecting multiple running items just like it has in the files tab where multiple items can be selected and operations can be performed on them. This functionality was also desired in the running tab which is resolved by this commit.

Since kernelList and terminalList inherits from the notebookList class there is option for including the functionality for selecting multiple items by passing true as one of the parameter when creating the list items. Although some other modifications had to be done to make it look similar to the files tab in the tree.html file and accordingly configure other parameters in the kernellist.js, main.js, notebooklist.js and terminallist.js.

closes #970

@kevin-bates
Copy link
Member

@Axle7XStriker - I'm sorry this has gone dormant. Since there's been some revived interest in this and it seems like a generally useful feature, would you mind resolving the current conflicts and we'll see if we can't get this kick-started?

We'll need to ask some of the front-end maintainers to review this following the rebase.

@Axle7XStriker
Copy link
Contributor Author

Sure, I'll have it rebased as soon as I can.

@kevin-bates
Copy link
Member

Fantastic - thank you!

@jasongrout - I'm sorry to always turn to you for front-end guidance but can you, or someone you know is familiar with this area, please review Aman's PR?

@Axle7XStriker Axle7XStriker force-pushed the selecting_multiple_running_items branch from 35c5888 to 1a24fa3 Compare March 8, 2020 21:06
@Axle7XStriker
Copy link
Contributor Author

I'm done with the rebase and have fixed some of the issues that were present, but I'm not able to understand why some of the tests are failing.

@kevin-bates
Copy link
Member

I wouldn't worry about that test failure as all of the more recent PRs are failing in the same way. Someone from the front-end needs to look into what's going on and, hopefully, also review your PR.

I'm not sure how testing works on the front-end but I see your PR doesn't appear to include any tests. That might be something the reviewer would like to see prior to its review.

@RAJSINGH-Bitian
Copy link

i would like to work with you. @Axle7XStriker will you pleasee let me in.

@jtpio
Copy link
Member

jtpio commented Oct 6, 2022

Thanks @Axle7XStriker for working on this and for your time 👍

This repository has undergone major changes to the code base in the past few months, and is now set to target the next major release (7.0) of the Jupyter Notebook application.

As mentioned in #970 (comment), this is now fixed on the latest main. This can also be tested with a pre-release: python -m pip install --pre notebook.

Closing as completed, thanks again!

@jtpio jtpio closed this Oct 6, 2022
@jtpio jtpio added this to the Reference milestone Oct 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing many notebooks at once
5 participants