-
Notifications
You must be signed in to change notification settings - Fork 368
Allows boostrap systemd check to pass if either systemd or systemctl are found
#1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
systemd or systemctl are foundsystemd or systemctl are found
systemd or systemctl are foundsystemd or systemctl are found
bootstrap/bootstrap.py
Outdated
| ) | ||
|
|
||
|
|
||
| def host_has_systemd() -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've added this function, but it's not used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good eye, whoops. I was contemplating breaking out more pieces to test before I noticed you already have an integration test suite running on GitHub Actions. I've stripped that part out, now to see if the other failures are relevant to this PR or not.
|
Switching to Draft until I sort out the build matrix failures |
|
The integration tests are flakey, they've passed after a rerun. |
Closes #1019.
Test log
Ubuntu 24.10 box with systemd installed
Correctly identifies the existence of
systemctl.Darwin box with no systemd
Correctly identifies no systemd present.
Test script used
Full test script for your reference: