Skip to content

Support traitlets versions < 5.0 #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Support traitlets versions < 5.0 #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/main/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,17 @@ class JupyterServer {
}
this._info.token = randomBytes(24).toString('hex');

// note: traitlets<5.0 require fully specified arguments to
// be followed by equals sign without a space; this can be
// removed once jupyter_server requires traitlets>5.0
this._nbServer = execFile(this._info.environment.path, [
'-m', 'jupyterlab',
'--no-browser',
// do not use any config file
'--JupyterApp.config_file_name', '',
'--JupyterApp.config_file_name=""',
// use our token rather than any pre-configured password
'--ServerApp.password', '',
'--ServerApp.allow_origin', '*'
'--ServerApp.password=""',
'--ServerApp.allow_origin="*"'
], {
cwd: home,
env: {
Expand Down