Fix ignored arrow keys

[krassowski]

Fixes #255

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[krassowski]

The fix is good, but I also noted: https://github.com/jupyterlab/lumino/pull/252/files#r739683874 and will improve that as well here.

[krassowski]

@blink1073 would it be a good idea to add Mac to CI matrix, or was it purposefully excluded?

lumino/.github/workflows/tests.yml

Lines 10 to 11 in 0f7378b

	matrix:
	os: [ubuntu-latest, windows-latest]

[jasongrout]

I added some more context and thoughts at #151 (comment), since that seems like the best place to consolidate the conversation across #151, #252, #255, and #256.

[blink1073]

@blink1073 would it be a good idea to add Mac to CI matrix, or was it purposefully excluded?

I don't remember the context at the time, but yes, we should be testing against Mac.