Use the secrets manager #53
Open
+105
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brichet
force-pushed
the
secrets-manager
branch
from
9c45c15 to
ef465fa
Compare
brichet
force-pushed
the
secrets-manager
branch
from
82bc22a to
0597746
Compare
jtpio
reviewed
Mar 11, 2025
| @@ -137,19 +138,20 @@ const providerRegistryPlugin: JupyterFrontEndPlugin<IAIProviderRegistry> = { | |||
| id: '@jupyterlite/ai:provider-registry', | |||
| autoStart: true, | |||
| requires: [IFormRendererRegistry, ISettingRegistry], | |||
| optional: [IRenderMimeRegistry], | |||
| optional: [IRenderMimeRegistry, ISecretsManager], | |||
There was a problem hiding this comment.
Looks like with this change, API keys are not stored on the page anymore since it will be using the default in-memory secret manager?
Wondering if we should still have a secret manager that stores secrets in the browser, for convenience? Or maybe have an option to choose between in-memory and in-browser storage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the secrets manager to handle passwords in settings.
The tests are not intended to work, since the secrets manager package has not been published yet.To test it, one should install locally jupyter-secrets-manager and use yalc to link the Javascript package.