Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to jupyterlite v0.2 #113

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Update to jupyterlite v0.2 #113

merged 6 commits into from
Nov 9, 2023

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Nov 8, 2023 •
edited
Loading

Fix #110

@martinRenou martinRenou added the enhancement New feature or request label Nov 8, 2023
@martinRenou martinRenou merged commit 72393f7 into jupyterlite:main Nov 9, 2023
@martinRenou martinRenou deleted the update_jupyterlite02 branch November 9, 2023 08:33
jtpio
jtpio reviewed Nov 13, 2023
View reviewed changes
docs/directives/notebooklite.md
`jupyterlite-sphinx` provides a `notebooklite` directive that allows you to embed the classic Notebook UI in your docs.

```rst
.. notebooklite::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just notebook could be enough? We don't make any use of notebooklite elsewhere.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe using an :app: parameter could help make this scale better in the future in case more apps are added?

Something like the following, using notebooks to match the name of the app in JupyterLite:

.. jupyterlite::
   :width: 100%
   :height: 600px
   :app: notebooks
   :prompt: Try classic Notebook!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Would you like to open an issue with this suggestion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just opened #114

@jtpio jtpio mentioned this pull request Nov 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to JupyterLite 0.2.0
2 participants
@martinRenou @jtpio