Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cwd for Notebooks #187

Merged
merged 4 commits into from
Feb 28, 2025
Merged

Fix cwd for Notebooks #187

merged 4 commits into from
Feb 28, 2025

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Feb 28, 2025 •
edited
Loading

Screenshot From 2025-02-28 10-01-46

@martinRenou martinRenou changed the title Debug location Fix cwd for Notebooks Feb 28, 2025
@martinRenou martinRenou marked this pull request as ready for review February 28, 2025 08:58
@martinRenou martinRenou added the bug Something isn't working label Feb 28, 2025
@martinRenou
Copy link
Member Author

please update snapshots

@martinRenou
Copy link
Member Author

The snapshots cannot be correct for both jupyterlite and jupyterlite --pre right now

@martinRenou martinRenou merged commit 3bdf9f3 into jupyterlite:main Feb 28, 2025
12 of 13 checks passed
@martinRenou martinRenou deleted the debug_location branch February 28, 2025 10:14
@jtpio
Copy link
Member

jtpio commented Mar 11, 2025

The snapshots cannot be correct for both jupyterlite and jupyterlite --pre right now

Should we skip the --pre snapshot test for now, so CI is not always broken?

Looks like this is related to jupyterlab/jupyterlab#17216

@jtpio jtpio mentioned this pull request Mar 11, 2025
Merged
@jtpio
Copy link
Member

jtpio commented Mar 11, 2025

Opened #192 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @jtpio