Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot the notebook section of the launcher only #192

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 11, 2025

Looking into fixing the CI, as a follow-up to #187 (comment)

Writing some more details here to better understand the situation and why it was failing.

It seems the failure was due to the following:

  • the UI tests now install xeus-r
  • JupyterLite 0.6.0 pre-releases (used in the UI tests) have updated to the JupyterLab 4.4.0 pre-releases which include the R logo update: Replace R logo with official logo jupyterlab/jupyterlab#17216
  • But the JupyterLite current stable release 0.5.x does not have this change, so it displays the old logo
  • Both the --pre and the default tests share the same snapshot

@jtpio jtpio marked this pull request as ready for review March 11, 2025 19:03
This was referenced Mar 11, 2025
@jtpio jtpio requested a review from martinRenou March 11, 2025 19:04
@jtpio
Copy link
Member Author

jtpio commented Mar 11, 2025

Looks like the docs failure is not related, not sure yet what it is.

So I opened #193 to fix it separately.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@martinRenou martinRenou merged commit 479b4d8 into jupyterlite:main Mar 11, 2025
13 of 14 checks passed
@jtpio jtpio deleted the fix-ui-tests branch March 11, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants