Multi envs support #164
Merged
Multi envs support #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be backward compatible 🤷🏽♂️ |
|
Working well on rtd! |
martinRenou
commented
Jan 24, 2025
| @@ -300,14 +298,16 @@ def copy_kernel(self, kernel_dir, kernel_wasm, kernel_js, kernel_data): | |||
| ], | |||
| ) | |||
|
|
|||
| yield from self.pack_prefix(kernel_dir=kernel_dir) | |||
| # pack prefix packages | |||
| # TODO Prevent duplication of the env pack for each kernel in it | |||
There was a problem hiding this comment.
I believe we should track that in an issue. Also if the same kernel is installed in two envs it will not work well, let's also track that in an issue.
Seems to be, but since it's a big change I'd prefer this to go on the 4.0.0 milestone |
martinRenou
force-pushed
the
multi_envs_support
branch
from
789e7a8 to
cf3f2a5
Compare
martinRenou
added a commit
to martinRenou/jupyterlite-xeus
that referenced
this pull request
Jan 28, 2025
This was introduced in jupyterlite#164 by mistake
martinRenou
added a commit
that referenced
this pull request
Jan 28, 2025
This was introduced in #164 by mistake
|
Just noticed this. Should it be mentioned in the docs? |
|
Opened #196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.