Open
Conversation
skdud0629
reviewed
Jan 7, 2025
| } | ||
|
|
||
| fun getMusicFilesData() { | ||
| val contentResolver: ContentResolver = requireContext().contentResolver |
There was a problem hiding this comment.
리사이클러뷰는 snake_case로 선언하시고 여기서는 camelCase를 사용하셨는데, 이렇게 통일하지 않고 사용하시면 코드의 가독성이 떨어질 수 있어요. 웬만해서는 네이밍 컨벤션 통일해주세요!
| } | ||
|
|
||
| class Adapter(private val data: MutableList<Item>) : RecyclerView.Adapter<Adapter.ViewHolder>() { | ||
| class Adapter(private val data: MutableList<Item>, private var name_view:TextView, private var time_view:TextView) : RecyclerView.Adapter<Adapter.ViewHolder>() { |
There was a problem hiding this comment.
recyclerview의 아이템 변동 사항이 없다면 MutableList 보단 불변 List를 사용하는 게 좋습니다!
불변성을 보장해 데이터 무결성을 유지할 수 있어용
| class PlayMusic : Service() { | ||
|
|
||
| private var mediaPlayer: MediaPlayer? = null | ||
| private val channel1 = "channel1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2025 01 06
매니패스트에 FOREGROUND_SERVICE라는 권한을 추가해야 한다고 하여 권한 확인하는 부분에 해당 권한을 허용하도록 함.
그런데 권한 허용 창이 뜨지 않길래 찾아보니 매니패스트에만 명시하면 되는 작업이라 함.
그래서 FOREGROUND_SERVICE권한 허용 코드가 있지만, 사용하지는 않음(다시 코드 수정하기 귀찮아서;; 어짜피 오류도 안나고)