Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [Trustpay] fix deserialization error for incoming webhook response for trustpay and add error code mapping '800.100.203' #4225

Merged
merged 2 commits into from
Mar 27, 2024
Merged

fix(connector): [Trustpay] fix deserialization error for incoming webhook response for trustpay and add error code mapping '800.100.203' #4225

merged 2 commits into from
Mar 27, 2024

Conversation

prasunna09
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • fix deserialization error for incoming webhook response for trustpay
    made Code as optional field
  • add error code mapping '800.100.203'

PR raised against main - #4199

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

No testing can be done since it matches error code in production which cant be replicated

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 @hyperswitch-bot
fix(connector): [Trustpay] fix deserialization error for incoming web…
7954516 
…hook response for trustpay and add error code mapping '800.100.203' (#4199)

Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Mar 27, 2024
@prasunna09 prasunna09 added this to the March 2024 milestone Mar 27, 2024
@prasunna09 prasunna09 self-assigned this Mar 27, 2024
@prasunna09 prasunna09 requested a review from a team as a code owner March 27, 2024 07:18
@Gnanasundari24 Gnanasundari24 merged commit e6dd608 into hotfix-2024.03.15.0 Mar 27, 2024
11 of 13 checks passed
@Gnanasundari24 Gnanasundari24 deleted the fix-parsing-error-wh branch March 27, 2024 09:09
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

@SamraatBansal SamraatBansal Awaiting requested review from SamraatBansal

Assignees

@prasunna09 prasunna09

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Milestone
March 2024 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@prasunna09 @ArjunKarthik @sai-harsha-vardhan @SanchithHegde @Gnanasundari24