fix(connector): [JPMORGAN, PAYU, DIGITALVIRGO, BITPAY, HELCIM, PAYBOX] Replaced lazystatic macros with LazyLock #7524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
bsayak03
changed the title
bsayak03
changed the title
Comment on lines
451
to
452
| static BITPAY_SUPPORTED_WEBHOOK_FLOWS: LazyLock<Vec<enums::EventClass>> = | ||
| LazyLock::new(|| vec![enums::EventClass::Payments]); |
There was a problem hiding this comment.
@AkshayaFoiger And this one can be an array instead possibly, depending on how it's being used?
There was a problem hiding this comment.
This can be an array, but this refactoring needs to be done for all the connectors that implements ConnectorSpecifications
…replaced lazystatic macros with LazyLock fix(connector): [JPMORGAN, PAYU, DIGITALVIRGO, HELCIM, PAYBOX, PAYU] Replaced lazystatic macros with LazyLock fix(connector): [JPMORGAN, PAYU, DIGITALVIRGO, HELCIM, PAYBOX, PAYU] Replaced lazystatic macros with LazyLock fix(connector): [JPMORGAN, PAYU, DIGITALVIRGO, HELCIM, PAYBOX, PAYU] Replaced lazystatic macros with LazyLock fix(connector): [JPMORGAN, PAYU, DIGITALVIRGO, HELCIM, PAYBOX, PAYU] Replaced lazystatic macros with LazyLock fix(connector): [JPMORGAN, PAYU, DIGITALVIRGO, HELCIM, PAYBOX, PAYU] Replaced lazystatic macros with LazyLock fix(connector): [JPMORGAN, PAYU, DIGITALVIRGO, HELCIM, PAYBOX, PAYU] Replaced lazystatic macros with LazyLock
bsayak03
force-pushed
the
feature_matrix_fix
branch
from
51ce499 to
8feab2f
Compare
| PaymentMethodDetails { | ||
| mandates: enums::FeatureStatus::NotSupported, | ||
| refunds: enums::FeatureStatus::Supported, | ||
| supported_capture_methods: supported_capture_methods.clone(), |
There was a problem hiding this comment.
Why the clone()? I don't see the supported_capture_methods variable being read anywhere?
Please make this change in the other files modified in this PR as well, where there's only one usage of the variable.
Comment on lines
449
to
450
| static BITPAY_SUPPORTED_WEBHOOK_FLOWS: LazyLock<[enums::EventClass; 1]> = | ||
| LazyLock::new(|| [enums::EventClass::Payments]); |
There was a problem hiding this comment.
Suggested change
| static BITPAY_SUPPORTED_WEBHOOK_FLOWS: LazyLock<[enums::EventClass; 1]> = | |
| LazyLock::new(|| [enums::EventClass::Payments]); | |
| static BITPAY_SUPPORTED_WEBHOOK_FLOWS: [enums::EventClass; 1] = [enums::EventClass::Payments]; |
added 2 commits
March 27, 2025 16:36
…] Replaced lazystatic macros with LazyLock
AkshayaFoiger
approved these changes
Mar 27, 2025
SanchithHegde
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Replaced lazystatic macros with LazyLock
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy