feat(router): add support for cost based debit routing #7542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it-routing/db-interface
ShankarSinghC
added
A-core
|
Review changes with Changed Files
|
ShankarSinghC
changed the title
vspecky
reviewed
Mar 19, 2025
config/development.toml
Outdated
Comment on lines
903
to
904
| [debit_routing_config] | ||
| fraud_check_fee = "0.01" |
There was a problem hiding this comment.
Is it possible to have these values as numbers in the config? With strings, there's a chance of a non-numeric value sneaking in somewhere.
Suggested change
| [debit_routing_config] | |
| fraud_check_fee = "0.01" | |
| [debit_routing_config] | |
| fraud_check_fee = 0.01 |
Comment on lines
158
to
160
| pub struct NoneRegulatedNetworkProcessingData { | ||
| pub merchant_category_code_0001: HashMap<enums::CardNetwork, NetworkProcessingData>, | ||
| } |
There was a problem hiding this comment.
How many category codes can there be? If it's more than 20, we should consider making this a HashMap instead.
| .change_context(errors::ApiErrorResponse::InternalServerError) | ||
| .attach_printable("Failed to convert fixed amount to f64 in interchange fee calculation")?; | ||
|
|
||
| let mut total_interchange_fee = (amount * percentage / 100.0) + fixed_amount; |
There was a problem hiding this comment.
Better to use .checked_mul() and .checked_div() to account for edge cases.
…spay/hyperswitch into debit-routing/app-cost-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This pull request introduces a new configuration for debit routing, including fees for fraud checks, network processing, and interchange. It also adds methods to calculate these fees and integrates them into the existing system.
For every payment that occurs, there are three fees associated with the network:
Network Fee
Every network has its own network fee structure, which typically includes both a percentage (% of the amount) and a fixed fee. For each payment, the respective network will charge a specific percentage and a fixed amount.
Interchange Fee
If the bank is a regulated bank, it can charge only a specified percentage and fixed amount for the transaction. If the bank is not a regulated bank, then, similar to the network fee, the bank can charge different amounts depending on the network.
Fraud Check Fee
When a bank is regulated under an exemption for fraud checks, it may charge an additional fee only if a fraud check is conducted.
When a payment is being performed all this factors should be taken in consideration and a network should be chosen according to merchant's configuration
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy